Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed injvm export and refer #3857

Merged
merged 4 commits into from
May 6, 2019
Merged

fixed injvm export and refer #3857

merged 4 commits into from
May 6, 2019

Conversation

Leishunyu
Copy link
Contributor

@Leishunyu Leishunyu commented Apr 11, 2019

What is the purpose of the change

#3638
Fixed bug in this issue

Brief changelog

Modified the original error logic

Verifying this change

    ServiceConfig<DemoServiceImpl> service = new ServiceConfig<>();
    ApplicationConfig applicationConfig = new ApplicationConfig("dubbo-demo-api-provider");
    service.setVersion("1.0.1");
    service.setProtocol(new ProtocolConfig("injvm"));
    service.setApplication(applicationConfig);
    //service.setScope("local");
    service.setInterface(DemoService.class);
    service.setRef(new DemoServiceImpl());
    service.export();
    ReferenceConfig<DemoService> reference = new ReferenceConfig<>();
    reference.setVersion("1.0.1");
    reference.setProtocol("injvm");
    //reference.setScope("local");
    reference.setApplication(applicationConfig);
    reference.setInterface(DemoService.class);
    DemoService serviceImpl = reference.get();
   serviceImpl.sayHello("111");

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@Leishunyu
Copy link
Contributor Author

@beiwei30 Can you help me see?

@CrazyHZM
Copy link
Member

Can you add some unit cases?

@Leishunyu
Copy link
Contributor Author

Can you add some unit cases?
The previous unit test has been covered

@codecov-io
Copy link

codecov-io commented Apr 30, 2019

Codecov Report

Merging #3857 into master will increase coverage by <.01%.
The diff coverage is 87.5%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #3857      +/-   ##
===========================================
+ Coverage      63.7%   63.7%   +<.01%     
  Complexity       71      71              
===========================================
  Files           712     743      +31     
  Lines         31450   32129     +679     
  Branches       5073    5123      +50     
===========================================
+ Hits          20034   20469     +435     
- Misses         9120    9306     +186     
- Partials       2296    2354      +58
Impacted Files Coverage Δ Complexity Δ
...in/java/org/apache/dubbo/config/ServiceConfig.java 58.2% <100%> (+1.62%) 0 <0> (ø) ⬇️
.../java/org/apache/dubbo/config/ReferenceConfig.java 59.85% <50%> (-1.38%) 0 <0> (ø)
...ava/org/apache/dubbo/common/utils/ClassHelper.java 0% <0%> (-69.1%) 0% <0%> (ø)
.../apache/dubbo/qos/protocol/QosProtocolWrapper.java 69.23% <0%> (-12.83%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyServerHandler.java 61.9% <0%> (-9.53%) 0% <0%> (ø)
...apache/dubbo/common/config/ConfigurationUtils.java 64% <0%> (-8%) 0% <0%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 51.42% <0%> (-5.72%) 0% <0%> (ø)
...ng/exchange/support/header/HeartbeatTimerTask.java 73.68% <0%> (-5.27%) 0% <0%> (ø)
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0%> (-5.27%) 0% <0%> (ø)
...e/dubbo/remoting/transport/netty4/NettyClient.java 70.58% <0%> (-4.02%) 0% <0%> (ø)
... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43f2a2a...e1b2a60. Read the comment docs.

@Leishunyu
Copy link
Contributor Author

@beiwei30 can you help me review

@beiwei30
Copy link
Member

on it.

@beiwei30 beiwei30 merged commit d11f204 into apache:master May 6, 2019
@beiwei30 beiwei30 mentioned this pull request May 6, 2019
@Leishunyu Leishunyu deleted the fix-injvm branch May 6, 2019 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants